[PATCH] D25960: Read section headers upfront

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 15:05:50 PDT 2016

On Tue, Oct 25, 2016 at 2:57 PM, Rafael EspĂ­ndola via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> On 25 October 2016 at 17:04, Davide Italiano <dccitaliano at gmail.com> wrote:
>> davide added a comment.
>> If you plan to iterate on this, probably it's fine, but my reaction when I see your number is that the performance effect of the change is pretty much neutral. Sure, you have some slowdowns and some improvements, but they vary roughly between 0.1% and 0.5% , which, no matter how controlled the enviroment on which we're running tests, could be caused by other factors.
> Yes, note that the objective is not to optimize in this change. The
> objective is to make it easier to create synthetic InputSections. I
> just wanted to make sure it was not a terrible idea from a performance
> perspective.

Makes perfectly sense, thanks for working on this. My main point is
that we shouldn't really worry about the "regressions" as they might
be caused by factors outside of our control.



More information about the llvm-commits mailing list