[PATCH] D25959: Introduce updateDiscriminator interface to DILocation to make it cleaner assigning discriminators.
Adrian Prantl via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 25 14:17:48 PDT 2016
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
This really simplifies the code a great deal.
Comment at: include/llvm/IR/DebugInfoMetadata.h:1274
+ /// Returns a new DILocation with updated \p Discriminator.
+ inline DILocation *cloneWithDiscriminator(unsigned Discriminator) const;
Should we leave the inlining decision to the compiler?
Comment at: include/llvm/IR/DebugInfoMetadata.h:1620
+ DIScope *Scope = getScope();
+ // Skip all parent DILexicalBlockFile that already has a discriminator
+ // assigned. We do not want to have nested DILexicalBlockFiles that has
has -> have (2x)
More information about the llvm-commits