[PATCH] D25956: Implement vector_insert_exp builtins - clang portion

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 13:11:09 PDT 2016

nemanjai added inline comments.

Comment at: lib/Headers/altivec.h:2500
+#ifdef __VSX__
+static __inline__ vector double  __ATTRS_o_ai
nemanjai wrote:
> Hmm... I think
> ```
> && __POWER9_VECTOR__
> ```
Actually, I take that back. It should only be __POWER9_VECTOR__.
This is important to get right because using this on a P8 or older machine will cause a run-time rather than a compile-time failure (i.e. it will compile just fine and executing the code would result in an illegal instruction).


More information about the llvm-commits mailing list