[PATCH] D25692: [AVX-512] Disassembler support for rounding control and SAE attribute.

[Elena Demikhovsky via llvm-commits]

delena added inline comments.


================
Comment at: lib/Target/X86/X86InstrAVX512.td:1886
                                     imm:$cc,
-                                (i32 FROUND_NO_EXC))>, EVEX_B;
+                                (i32 FROUND_NO_EXC))>, VEX_LIG, EVEX_B;
 
----------------
I don't see LIG specification in the "sae" form of VCMP:

EVEX.NDS.512.66.0F.W1 C2 /r ib FV V/V AVX512F Compare packed double-precision floating-point values
in zmm3/m512/m64bcst and zmm2 using bits 4:0 of
imm8 as a comparison predicate with writemask k2
and leave the result in mask register k1.
VCMPPD k1 {k2}, zmm2,
zmm3/m512/m64bcst{sae}, imm8


================
Comment at: lib/Target/X86/X86InstrAVX512.td:5817
+    defm Z : avx512_cvt_fp_rc_scalar<opc, OpcodeStr, _dst, _src,
+                               OpNodeRnd>, VEX_W, EVEX_CD8<64, CD8VT1>, XD;
   }
----------------
Why do you need to remove EVEX_V512 from the second pattern?


https://reviews.llvm.org/D25692