[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 11:26:21 PDT 2016

On Tue, Oct 25, 2016 at 11:08 AM, Eugene Leviant <evgeny.leviant at gmail.com>

> evgeny777 added inline comments.
> ================
> Comment at: ELF/InputFiles.cpp:56
> +
> +template <class ELFT> DIHelper<ELFT>::~DIHelper() { delete DwarfLine; }
> +
> ----------------
> ruiu wrote:
> > Use unique_ptr to remove this dtor.
> It's not possible unless you include DWARFContext.h to InputFiles.h or
> override unique_ptr deleter (second template parameter). Is this better?

You can have an empty dtor in InputFiles.cpp like `template <class ELFT>
DIHelper<ELFT>::~DIHelper() {}` to write a definition of the dtor in the
cpp file instead of in the header so that you don't need to include the
DWARFContext.h, can't you?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161025/19843399/attachment.html>

More information about the llvm-commits mailing list