[PATCH] D25929: Add llvm-echo command.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 09:24:54 PDT 2016


rnk added a comment.

In https://reviews.llvm.org/D25929#578441, @mgorny wrote:

> That said, I don't understand why would you need to tokenize arguments to echo.


If the kernel gives you argv directly, then you don't need to tokenize. If, as on Windows, the kernel gives userspace a quoted string, then different executables may interpret it differently. We've had problems with shell commands like `echo '"'` where the way CPython quotes the string isn't compatible with the way MSys echo tokenizes it. See https://reviews.llvm.org/rL284768. We could try to standardize on printf everywhere, but it's hard to enforce that for new tests.


https://reviews.llvm.org/D25929





More information about the llvm-commits mailing list