[PATCH] D25915: [PPC] add vector byte reverse functions to altivec.h

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 25 06:27:36 PDT 2016


nemanjai added a comment.

I think this patch looks fine but I'll let @kbarton review and provide approval.
BTW. you and @jtony have a conflict in the test case so the first to commit wins and the other one will have to make some changes on the commit.



================
Comment at: test/CodeGen/builtins-ppc-altivec.c:9040
+// CHECK-LE: store <16 x i8> <i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1, i8 -1>, <16 x i8>* {{%.+}}, align 16
+// CHECK-LE: {{%.+}} = xor <16 x i8>
+// CHECK-LE: {{%.+}} = call <4 x i32> @llvm.ppc.altivec.vperm(<4 x i32> {{%.+}}, <4 x i32> {{%.+}}, <16 x i8> {{%.+}})
----------------
This is minor and can just be done on the commit, but I don't think this regex portion is needed. I'd just make these check lines:
`//CHECK-LE: xor <16 x i8>`


Repository:
  rL LLVM

https://reviews.llvm.org/D25915





More information about the llvm-commits mailing list