[PATCH] D25627: [ELF] Allow linker script to use .got and .got.plt sections as inputs

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 18:47:12 PDT 2016


ruiu added a comment.

I think this is still too large to see whether the very concept of virtual input section is good or not. GOT section is used everywhere, so you had to update so many places to convert it. Could you convert much less important section first? Say, build-id?



================
Comment at: ELF/InputSection.h:351
+protected:
+  typename ELFT::Shdr Header;
+};
----------------
Does `Header = {};` initialize with zero?


https://reviews.llvm.org/D25627





More information about the llvm-commits mailing list