[compiler-rt] r284901 - [sanitizers] support strict_string_checks for strncmp

Kostya Serebryany via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 13:28:24 PDT 2016

On Mon, Oct 24, 2016 at 12:16 PM, Tim Northover <t.p.northover at gmail.com>

> Hi Kostya,
> On 21 October 2016 at 16:52, Kostya Serebryany via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > [sanitizers] support strict_string_checks for strncmp
> This seems to have caused some failures on Green Dragon:
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/928/
> for example. To me it looked like both messages are about as good and
> it was likely caused by different strstr implementations across OSs,
> so I committed r285004 relaxing the tests slightly.
> Does that reasoning & change look reasonable to you?

Hard to be 100% sure w/o looking into the details on Mac, but most likely
you are right.
Thanks for the fix!


> Cheers.
> Tim.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161024/90e3794e/attachment.html>

More information about the llvm-commits mailing list