[PATCH] D25691: [DAGCombiner] Add vector demanded elements support to computeKnownBits

Bjorn Pettersson via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 13:03:06 PDT 2016

bjope added inline comments.

Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2568
   case ISD::BSWAP: {
     computeKnownBits(Op.getOperand(0), KnownZero2, KnownOne2, Depth+1);
     KnownZero = KnownZero2.byteSwap();
bjope wrote:
> Any reason for not providing the DemandedElts in this recursive call?
Sorry, I just realised that BSWAP wasn't the only operation not providing DemandedElts in the recursive call.
So I have no special interest in BSWAP. But I guess that there is a general TODO to pass DemandedElts in many more recursive calls.



More information about the llvm-commits mailing list