[PATCH] D25917: Target: Change various section classifiers in TargetObjectFile to take a GlobalObject.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 12:08:06 PDT 2016


pcc created this revision.
pcc added a reviewer: echristo.
pcc added a subscriber: llvm-commits.
Herald added subscribers: nhaehnle, nemanjai, mehdi_amini, arsenm, jholewinski.
Herald added a reviewer: tstellarAMD.

These functions are about classifying a global which will actually be
emitted, so it does not make sense for them to take a GlobalValue which may
for example be an alias.

Change the Mach-O object writer and the Hexagon, Lanai and MIPS backends
to look through aliases before using TargetObjectFile interfaces. These are
functional changes but all appear to be bug fixes.


https://reviews.llvm.org/D25917

Files:
  llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
  llvm/include/llvm/IR/GlobalValue.h
  llvm/include/llvm/Target/TargetLoweringObjectFile.h
  llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
  llvm/lib/IR/Globals.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetObjectFile.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetObjectFile.h
  llvm/lib/Target/AVR/AVRTargetObjectFile.cpp
  llvm/lib/Target/AVR/AVRTargetObjectFile.h
  llvm/lib/Target/Hexagon/HexagonISelLowering.cpp
  llvm/lib/Target/Hexagon/HexagonTargetObjectFile.cpp
  llvm/lib/Target/Hexagon/HexagonTargetObjectFile.h
  llvm/lib/Target/Lanai/LanaiISelLowering.cpp
  llvm/lib/Target/Lanai/LanaiTargetObjectFile.cpp
  llvm/lib/Target/Lanai/LanaiTargetObjectFile.h
  llvm/lib/Target/Mips/MipsISelLowering.cpp
  llvm/lib/Target/Mips/MipsTargetObjectFile.cpp
  llvm/lib/Target/Mips/MipsTargetObjectFile.h
  llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
  llvm/lib/Target/NVPTX/NVPTXTargetObjectFile.h
  llvm/lib/Target/PowerPC/PPCTargetObjectFile.cpp
  llvm/lib/Target/PowerPC/PPCTargetObjectFile.h
  llvm/lib/Target/TargetLoweringObjectFile.cpp
  llvm/lib/Target/XCore/XCoreTargetObjectFile.cpp
  llvm/lib/Target/XCore/XCoreTargetObjectFile.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25917.75622.patch
Type: text/x-patch
Size: 49666 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161024/51362d24/attachment.bin>


More information about the llvm-commits mailing list