[PATCH] D25906: [PPC] Implement vector reverse elements builtins (vec_reve)

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 09:53:02 PDT 2016

amehsan added inline comments.

Comment at: test/CodeGen/builtins-ppc-altivec.c:9014
+// check-label: define void @test8
+void test8() {
amehsan wrote:
> nemanjai wrote:
> > nemanjai wrote:
> > > Please provide CHECK-LABEL for all the check prefixes and keep the checks upper case (I'm not sure if this actually performs the LABEL check).
> > I just realized that the existing tests in this file don't check the label for both prefixes. That's fine and you're not expected to change that, but since you're writing a new test, provide both
> Something that I do sometimes to make sure my test is actually doing something is the following. I change the testcase slightly so it has to fail. Then I check again. If it passes, then something is wrong.
I think this comment should have been further down in the file :P


More information about the llvm-commits mailing list