[PATCH] D25906: [PPC] Implement vector reverse elements builtins (vec_reve)

Nemanja Ivanovic via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 24 09:28:08 PDT 2016


nemanjai added inline comments.


================
Comment at: test/CodeGen/builtins-ppc-altivec.c:9014
+
+// check-label: define void @test8
+void test8() {
----------------
nemanjai wrote:
> Please provide CHECK-LABEL for all the check prefixes and keep the checks upper case (I'm not sure if this actually performs the LABEL check).
I just realized that the existing tests in this file don't check the label for both prefixes. That's fine and you're not expected to change that, but since you're writing a new test, provide both
CHECK-LABEL:
CHECK-LE-LABEL:


https://reviews.llvm.org/D25906





More information about the llvm-commits mailing list