[PATCH] D25829: AMDGPU: Fix SILoadStoreOptimizer when writes cannot be merged due register dependencies
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 24 05:58:28 PDT 2016
arsenm added a comment.
In https://reviews.llvm.org/D25829#577494, @arsenm wrote:
> Should this be using MachineInstr::isSafeToMove instead of this custom logic?
After looking at the implementation this isn't right. The comment for it seems misleading to me since it doesn't take an iterator for where you're moving it, and only checks a few things on the single instruction
More information about the llvm-commits