[PATCH] D25697: Make the LTO comdat api more symbol table friendly
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 21 14:36:32 PDT 2016
davide added a comment.
Thank you for taking care of my comments. I'm happy with it. Mehdi, what do you think?
Comment at: include/llvm/LTO/LTO.h:185-188
+ // Returns the index of the comdat this symbol is in or -1 if the symbol
+ // is not in a comdat.
+ // FIXME: We have to return Expected<int> because of the way aliases are
+ // implemented and the lack of a IR symbol table.
Uh, this is not ideal. Hopefully we can get rid of it once we migrate to a bitcode symtab.
More information about the llvm-commits