[PATCH] D25826: [ELF] Show error location for 'undefined symbol' errors
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 21 14:18:56 PDT 2016
ruiu added inline comments.
Comment at: ELF/Relocations.cpp:569-571
+ warn(Location, Msg);
+ error(Location, Msg);
> ruiu wrote:
> > Now that you can just concatenate strings before passing to the functions.
> > warn(Location + ": " + Msg);
> > error(Location + ": " + Msg);
> > So I think you don't need to add new overloaded functions to error.cpp.
> Actually location and message are separated by message type, i.e:
> <Location> : warning : <Msg>
Did you have a reason to break consistency that way here?
More information about the llvm-commits