[PATCH] D25645: [ADT] Add CachedHashString.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 13:43:01 PDT 2016


mehdi_amini added a comment.

In https://reviews.llvm.org/D25645#574862, @mehdi_amini wrote:

> Couldn't `CachedHashString` just wrap a `CachedHashStringRef`?
>
> Or even have a single implementation:
>
>   template<bool Owning>
>   class CachedHashStringRefBase {
>     ...
>  
>     ~CachedHashStringRefBase() {
>       if (owning) delete...
>   }
>   using CachedHashStringRef = CachedHashStringRefBase<false>;
>   using CachedHashString = CachedHashStringRefBase<true>;
>  
>


Ping?


Repository:
  rL LLVM

https://reviews.llvm.org/D25645





More information about the llvm-commits mailing list