[PATCH] D25881: [EarlyCSE] Optimize MemoryPhis and reduce memory clobber queries w/ MemorySSA
Daniel Berlin via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 21 13:15:24 PDT 2016
(IE you can use getClobberingAccess always, and not worry about it)
On Fri, Oct 21, 2016 at 1:14 PM, Daniel Berlin <dberlin at dberlin.org> wrote:
> "Also, when using MemorySSA to check if two MemoryUses are reading from
> the same version of the heap, use the defining access instead of calling
> getClobberingAccess, since the latter can currently result in many more
> AA calls."
> This should be fixed as of yesterday.
> On Fri, Oct 21, 2016 at 1:12 PM, Geoff Berry <gberry at codeaurora.org>
>> gberry created this revision.
>> gberry added a reviewer: dberlin.
>> gberry added subscribers: llvm-commits, mcrosier.
>> When using MemorySSA, re-optimize MemoryPhis when removing a store since
>> this may create MemoryPhis with all identical arguments.
>> Also, when using MemorySSA to check if two MemoryUses are reading from
>> the same version of the heap, use the defining access instead of calling
>> getClobberingAccess, since the latter can currently result in many more
>> AA calls. Once the MemorySSA use optimization tracking changes are
>> done, we can remove this limitation, which should result in more loads
>> being CSE'd.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits