[PATCH] D25862: X86: Improve BT instruction selection for 64-bit values.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 11:47:13 PDT 2016


pcc added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:15317
+    DAG.computeKnownBits(BitNo, Zeros, Ones);
+    if (Zeros[5])
+      Src = DAG.getNode(ISD::TRUNCATE, dl, MVT::i32, Src);
----------------
RKSimon wrote:
> Would this be cleaner with DAG.MaskedValueIsZero()?
Yes, done.


https://reviews.llvm.org/D25862





More information about the llvm-commits mailing list