[PATCH] D25763: Add end location of loop to loop metadata.

Hal Finkel via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 08:39:53 PDT 2016


hfinkel added a comment.

> The patch adds the loop end location to the loop metadata. This additional information can be used to improve the locations when generating remarks for loops.

How, exactly, do you plan on using this information to make the remarks better? I thought about doing this when I added the location information to the loop metadata in the first place, and figured that pointing to the start of the loop would unambiguously identify it. This could be useful for highlighting the entire loop body without having an AST available. I'd like to know what you're thinking.


https://reviews.llvm.org/D25763





More information about the llvm-commits mailing list