[PATCH] D25781: AMDGPU: Emit runtime metadata as a note element in .note section

[Tom Stellard via llvm-commits]

tstellarAMD added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:47-84
+namespace AMDGPU {
+
+  // Class for emitting runtime metadata as a note element in .note section.
+  // To emit runtime metadata, define an instance of this class.
+  class EmitRuntimeMD{
+  public:
+    EmitRuntimeMD(MCStreamer &S, Module &M) : S(S) {
----------------
These functions belong in AMDGPUTargetStreamer classes.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:14
 
+#include "AMDGPUNoteType.h"
 #include "AMDGPUTargetStreamer.h"
----------------
Are the changes in this file necessary?


https://reviews.llvm.org/D25781