[PATCH] D25829: AMDGPU: Fix SILoadStoreOptimizer when writes cannot be merged due register dependencies

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 21 01:50:08 PDT 2016

nhaehnle added inline comments.

Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:259
+    //   w = DS_READ_B32 addr, idx0
+    //   DS_WRITE_B32 addr, f(w), idx1
+    // where the DS_READ_B32 ends up in InstsToMove and therefore prevents
tstellarAMD wrote:
> What does f(w) mean in this comment?  Also, before this patch was this pass merging these two writes?
It's supposed to mean some function of w :)

Before this patch, the writes were merged and compilation failed later because "use not dominated by defs".


More information about the llvm-commits mailing list