[PATCH] D20019: [PPC] exploitation of new xscmp*, as well as xsmaxcdp and xsmincdp

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 18:09:53 PDT 2016

echristo added a comment.

A couple of inline comments and one general question: With Nemanjai we've been saying that we didn't want to add subtarget features for every ISA addition of the default ISA, what's with this one? :)



Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2903-2932
+        if (Summary.Comp0 == Summary.Ret0 && Summary.Comp1 == Summary.Ret1) {
+          unsigned MaxOpcode = (Summary.RetType == MVT::f32) ?
+                                  PPC::XSMAXCDP_SP : PPC::XSMAXCDP;
+          CurDAG->SelectNodeTo(N, MaxOpcode, Summary.RetType,
+                               Summary.Ret0, Summary.Ret1);
+          return;
+        }
Go ahead and document what's going on in each block here if you wouldn't mind.

Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:6252
+  if (Subtarget.hasP9VSXScalarFPCompMinMax())
+    return Op;
Add a simple comment here would be nice.


More information about the llvm-commits mailing list