[PATCH] D25847: [ValueTracking] Don't assume we can speculate shifts

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 16:09:40 PDT 2016

mkuper added inline comments.

Comment at: lib/Analysis/ValueTracking.cpp:3217
     return true;
+  //TODO: Div, rem and shifts can probably be smarter about non-constant values,
+  //and use known bits.
davide wrote:
> Nit: I think the LLVM spelling is `FIXME`
This is really inconsistent, both are used.

%%%lib$ grep -R "// TODO" | wc -l
lib$ grep -R "// FIXME" | wc -l

We do consistently have a space after the // , though.
I'll change to "// FIXME:" to match the leading style. :-)


More information about the llvm-commits mailing list