[PATCH] D25847: [ValueTracking] Don't assume we can speculate shifts

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 16:02:10 PDT 2016

davide added a comment.

LGTM, modulo nit. This was a little bit painful.

Comment at: lib/Analysis/ValueTracking.cpp:3217
     return true;
+  //TODO: Div, rem and shifts can probably be smarter about non-constant values,
+  //and use known bits.
Nit: I think the LLVM spelling is `FIXME`


More information about the llvm-commits mailing list