[PATCH] D25846: scripts: Document existing problems with the symbolizer build script.

[Peter Collingbourne via llvm-commits]

pcc created this revision.
pcc added reviewers: eugenis, vitalybuka.
pcc added a subscriber: llvm-commits.
Herald added a subscriber: kubabrecka.

https://reviews.llvm.org/D25846

Files:
  compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh


Index: compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
===================================================================
--- compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
+++ compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
@@ -18,6 +18,12 @@
 #
 # The script will modify the output directory which is given as the first
 # argument to the script.
+#
+# FIXME: We should really be using a simpler approach to building this object
+# file, and it should be available as a regular cmake rule. Conceptually, we
+# want to be doing "ld -r" followed by "objcopy -G" to create a relocatable
+# object file with only our entry points exposed. However, this does not work at
+# present, see PR30750.
 
 SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
 SRC_DIR=$(readlink -f $SCRIPT_DIR/..)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25846.75361.patch
Type: text/x-patch
Size: 853 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161020/3dd537a4/attachment.bin>