[llvm] r280750 - Avoid using alignas and constexpr.
Reid Kleckner via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 20 14:18:34 PDT 2016
On Wed, Oct 19, 2016 at 12:02 AM, Justin Bogner <mail at justinbogner.com>
> Rafael Espindola via llvm-commits <llvm-commits at lists.llvm.org> writes:
> > Author: rafael
> > Date: Tue Sep 6 15:36:24 2016
> > New Revision: 280750
> > URL: http://llvm.org/viewvc/llvm-project?rev=280750&view=rev
> > Log:
> > Avoid using alignas and constexpr.
> > This requires removing the custom allocator, since Demangle cannot
> > depend on Support and so cannot use Compiler.h.
> Can we use alignas and constexpr now that we're dropping MSVC 2013, or
> did these also cause problems on other compilers? If 2013 was the
> bottleneck, should we add back the custom allocator here?
Go for it, I tried out the basic constructs with MSVC 2015 and it all
works. The only question is, do you think the custom arena allocator is
worth it? For a demangler, it might be.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits