[PATCH] D25679: Do not assume that FP vector operands are never legalized by expanding

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 13:16:20 PDT 2016

efriedma added a comment.

As far as I can tell, ExpandOp_BITCAST can be called with two kinds of nodes: a bitcast where the operand is a large illegal integer type (DAGTypeLegalizer::ExpandIntegerOperand), and a bitcast where the operand is of type ppc_fp128 (DAGTypeLegalizer::ExpandFloatOperand; the name is slightly misleading, but it is in fact only used for ppc_fp128).  So this should have no effect anywhere outside of PPC targets.

Given that, it's probably a good idea to reorganize the code so it's less likely someone will break ppc_fp128 in the future... but the bugfix is fine.



More information about the llvm-commits mailing list