[PATCH] D25814: [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 12:51:55 PDT 2016


eugenis added inline comments.


================
Comment at: test/msan/Linux/syscalls_sigaction.cc:21
+#if defined(__mips__)
+  long restorer;
+#endif
----------------
Are you sure that restorer follows mask? Length of the mask field (20 here) does not match any kernel definition - it is simply large enough to avoid out-of-bounds access.

The kernel definition does not seem to have a restorer field at all.



Repository:
  rL LLVM

https://reviews.llvm.org/D25814





More information about the llvm-commits mailing list