[PATCH] D19761: [safestack] Support runtime_init attribute in SafeStack pass

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 12:41:59 PDT 2016


eugenis added a comment.

Do you really need all this complexity, and even a magic function attribute (which is btw entirely safestack-specific, so should have "safestack" in the name)?

We've had the same problem on Android, and were able to solve it entirely on the libc side:
https://android-review.googlesource.com/#/c/170988/23/linker/linker_main.cpp

Alternatively, consider moving this code into a runtime library function. Then SafeStack instrumentation would just call a function in the prologue instead of reading from a global. This would be good for code size.


https://reviews.llvm.org/D19761





More information about the llvm-commits mailing list