[PATCH] D24525: [Power9] Processor Model for Scheduling

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 12:15:04 PDT 2016

echristo accepted this revision.
echristo added a comment.

Few inline comments, nothing major and nothing that can't be added later.

Comment at: lib/Target/PowerPC/P9InstrResources.td:17
+def : InstRW<[P9_ALUE_2C, P9_ALUO_2C, IP_EXECE_1C, IP_EXECO_1C,
General request: It would be nice if the pipeline were documented in some way here. Otherwise this is pretty much a wall of incomprehensible text :)

Comment at: lib/Target/PowerPC/P9InstrResources.td:219
+      (instrs
+ //   VABSDUB, // Uncomment when support for these instructions was added.
+ //   VABSDUH,

and add a TODO: in front.


More information about the llvm-commits mailing list