[PATCH] D25805: [AMDGPU] Perform uchar to float combine for ISD::SINT_TO_FP

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 07:36:15 PDT 2016

tstellarAMD added inline comments.

Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:3560
+  case ISD::SINT_TO_FP:
   case ISD::UINT_TO_FP: {
I don't think this is correct, because it's replacing SINT_TO_FP with CVT_F32_UBYTE0, which is an unsigned conversion.


More information about the llvm-commits mailing list