[PATCH] D25656: AMDGPU: Allow additional implicit operands on MOVRELS instructions

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 06:43:06 PDT 2016


tstellarAMD added a comment.

In https://reviews.llvm.org/D25656#572773, @nhaehnle wrote:

> Adding a test case.
>
> The test case is quite fragile because the problem comes from
>  ScheduleDAGInstrs::fixupKills, which seems to have a bunch of subtle
>  problems with sub-registers, and generally the code just doesn't really
>  do what the comments seem to think it does. But fixing that may not be
>  worth it since the whole thing has a FIXME on it suggesting to switch it
>  all to LivePhysRegs.


Would it be easier to write an MIR tests case?


https://reviews.llvm.org/D25656





More information about the llvm-commits mailing list