[PATCH] D24706: [ELF] - Partial support of --gdb-index command line option (Part 1).

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 18:39:20 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

Please land this patch with the following fixes.



================
Comment at: ELF/GdbIndex.h:15
+#include "llvm/Object/ELF.h"
+#include "llvm/DebugInfo/DWARF/DWARFContext.h"
+
----------------
Move this to the .cpp file.


================
Comment at: ELF/Options.td:96-102
 def image_base : J<"image-base=">, HelpText<"Set the base address">;
 
+def gdb_index: F<"gdb-index">,
+  HelpText<"Generate .gdb_index section">;
+
 def init: S<"init">, MetaVarName<"<symbol>">,
   HelpText<"Specify an initializer function">;
----------------
Sort.


================
Comment at: ELF/Writer.cpp:775
+  Out<ELFT>::DebugInfo    = findSection(".debug_info");
+
   Out<ELFT>::PreinitArray = findSection(".preinit_array");
----------------
Remove the blank line and clang-format.


https://reviews.llvm.org/D24706





More information about the llvm-commits mailing list