[PATCH] D25784: [Support] ThreadPool: Don't spawn any threads when ThreadCount = 1

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 17:03:30 PDT 2016

vsk added a comment.

In https://reviews.llvm.org/D25784#574859, @mehdi_amini wrote:

> I may miss something, but I'm seeing this "hiding a latent bug", and as such is not a great motivation (it means that there might be a latent bug with the threading infrastructure and/or llvm-cov, possibly on a particular platform, but you're reducing the coverage on this aspect).

In this particular case (PR30735), we still have tests that stress the multi-threaded path on the affected platform, so the coverage hasn't been removed altogether. I don't expect this kind of change to eradicate the bug, and am still searching for the root cause.

Separately, I still think it should be possible to avoid paying the thread creation overhead when using ThreadPool with LLVM_ENABLE_THREADS=On.


More information about the llvm-commits mailing list