[PATCH] D25693: [AMDGPU] Emit constant address space data in .rodata section and use relocations instead of fixups (amdhsa only)

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 11:53:26 PDT 2016

tstellarAMD added inline comments.

Comment at: test/CodeGen/AMDGPU/global-constant.ll:4-6
 @readonly = private unnamed_addr addrspace(2) constant [4 x float] [float 0.0, float 1.0, float 2.0, float 3.0]
 @readonly2 = private unnamed_addr addrspace(2) constant [4 x float] [float 4.0, float 5.0, float 6.0, float 7.0]
I think this patch also fixes the case where we have an external variable in address space 2.  I would add a test for that here.  If I'm wrong and this patch doesn't fix this, then we can add the test case along with the fix for it in a follow-up patch.


More information about the llvm-commits mailing list