[PATCH] D24795: [ELF] Linkerscript: Try to put section to the last PT_LOAD, in case there is no exact segment specification

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 07:29:47 PDT 2016

evgeny777 added inline comments.

Comment at: ELF/LinkerScript.cpp:713
     if (!PhdrIds.empty()) {
       // Assign headers specified by linker script
evgeny777 wrote:
> rafael wrote:
> > This if is not necessary anymore, no?
> Not exactly. You may have no PT_LOAD segments in PHDRS directive. GNU gold (bunutils 2.26) crashes in such case. I think we shouldn't
On the second look I see that you're right. Will update diff.


More information about the llvm-commits mailing list