[PATCH] D17260: SystemZ scheduling implementation

Jonas Paulsson via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 06:44:59 PDT 2016

jonpa added inline comments.

Comment at: lib/Target/SystemZ/SystemZHazardRecognizer.cpp:47
+  if (!SC->isValid())
+    return 0; // IMPLICIT_DEF / KILL -- will not make impact in output.
uweigand wrote:
> This looks OK to me.  However, with this change we should now give a scheduling class to the DirectiveInsn pesudo instruction -- these do emit some instruction, we just don't know which one, so it should probably be modeled as some "generic" instruction.
I used an empty InstRW construct, which seems to do the job.


More information about the llvm-commits mailing list