[PATCH] D25721: [LLD][ARM] Allow relative exceptions relocations in shared libraries

Peter Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 06:30:04 PDT 2016


peter.smith updated this revision to Diff 75135.
peter.smith added a comment.

Thank you for the review. I've implemented the suggestion to add a R_TLSDESC_CALL RelExpr and used R_HINT for R_ARM_NONE and R_MIPS_JALR.

It could be possible to get rid of R_TLSDESC_CALL by replacing "Expr == R_TLSDESC_CALL" by 
"Expr == R_HINT && Target->isTlsDescCall(Type)"

However I think that R_TLSDESC_CALL is worth keeping individually as it is common to x86, ARM and AArch64 even if it is only implemented in AArch64 in lld.


https://reviews.llvm.org/D25721

Files:
  ELF/InputSection.cpp
  ELF/Relocations.cpp
  ELF/Relocations.h
  ELF/Target.cpp
  test/ELF/arm-exidx-shared.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25721.75135.patch
Type: text/x-patch
Size: 5783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161019/bcbdf9f2/attachment.bin>


More information about the llvm-commits mailing list