[PATCH] D24665: [Sparc][LEON] Fixes an erratum on UT699 LEON 3 processor changing rounding mode

Daniel Cederman via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 06:12:28 PDT 2016


dcederman accepted this revision.
dcederman added a comment.
This revision is now accepted and ready to land.

Now it looks good to me.

I've noticed that some of the source files you have committed previously have accidentally been marked as executable. Perhaps you could change that for the files touched in this patch?



================
Comment at: lib/Target/Sparc/LeonPasses.cpp:319
+
+  return Modified;
+}
----------------
Modified is always false now, so you could return false directly to make it clearer that the pass does not change anything.


https://reviews.llvm.org/D24665





More information about the llvm-commits mailing list