[PATCH] D25501: [Orc] Specialize SerializationTraits on (un)signed char to fix SunOS

Michał Górny via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 05:22:39 PDT 2016

mgorny added a comment.

In https://reviews.llvm.org/D25501#573356, @lhames wrote:

> Hi Michał,
> That's interesting. I think I ran into almost the opposite problem while working on an update to this code: leaving out a specialization for char caused a 'missing specialization' error.
> Let me look into this: I suspect we'll actually want to use SFINAE tricks to enable/disable one of the specializations.

That was my first thought as well. However, my C++ skills were not enough to be able to get a working SFINAE for this problem. So I went for the simplest alternative, that is specializing all three possible `char` variants.


More information about the llvm-commits mailing list