[PATCH] D25738: [IndVarSimplify] Use control-dependent range information to prove non-negativity

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 05:19:19 PDT 2016


apilipenko marked 8 inline comments as done.
apilipenko added inline comments.


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:1607
+       DTB = DTB->getIDom()) {
+    auto TI = DTB->getBlock()->getTerminator();
+
----------------
sanjoy wrote:
> `auto *` here.
> 
> I'd actually just remove `TI` altogether -- and instead do:
> 
> ```
> auto *BI = dyn_cast<BranchInst>(DTB->getBlock()->getTerminator());
> ```
> 
I'll need TI for guards here (see D25739).


https://reviews.llvm.org/D25738





More information about the llvm-commits mailing list