[PATCH] D25615: [Thumb-1] Synthesize TBB/TBH instructions to make use of compressed jump tables

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 04:10:28 PDT 2016

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Hi James,

The code looks good to me, and I think the idea is a good one, including performance of Thumb1 cores.

LGTM. Thanks!

Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:1774
+    // could more simply just emit the label 2 bytes earlier. We take the easy
+    // option.
+    OutStreamer->EmitLabel(GetCPISymbol(MI->getOperand(3).getImm()));
Changing the table format/alignment looks like a code-size optimisation, so can be done later.



More information about the llvm-commits mailing list