[PATCH] D25276: [LoopVectorizer] Interleaved-mem-accesses analysis and getPtrStride
Dorit Nuzman via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 19 00:57:44 PDT 2016
dorit added a comment.
In https://reviews.llvm.org/D25276#573182, @sbaranga wrote:
> In https://reviews.llvm.org/D25276#573001, @dorit wrote:
> > I see. Thanks.
> > So in this case, don't we have a problem of potentially adding runtime SCEV assumptions without ever checking if we exceed the threshold? getPtrStride is called with Assume=true several times from the cost-model stage and from the actual vectorization transformation stage, via the call to isConsecutivePtr. Looks like these call sites are past the point when we check whether we exceeded the threshold for runtime SCEV assumptions...?
> Yes, I think that would be the case.
I will open a PR to capture all the SCEV threshold issues that came up here, including the xfailing test I just added.
> We should also move the check for the number of SCEV assumptions after the legality stage of the vectorizer (I thought we already did that).
so what exactly do you mean? It's already the very last thing we do in canVectorize...?
More information about the llvm-commits