[llvm] r284513 - revert r284495: [Target] remove TargetRecip class

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 15:40:23 PDT 2016


On 18 October 2016 at 15:13, Sanjay Patel <spatel at rotateright.com> wrote:
> Is a solution to return a std::string rather than a StringRef because the
> string will then be an actual copy rather than a reference?

Oh, actually it looks like I was mistaken. I didn't see that
getValueAsString and getAsString were different when I looked at the
docs.

I can't see anything else obviously wrong either. I'll try to take a
better look in a bit, but I've got 3 independent bot failures on my
hands now and no real clue about any of them so it may take a while.

Sorry.

Tim.


More information about the llvm-commits mailing list