[PATCH] D24808: [AArch64] Avoid materializing 0.0 when generating FP CSEL

Sebastian Pop via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 12:33:18 PDT 2016


sebpop added a comment.

In https://reviews.llvm.org/D24808#573402, @rengolin wrote:

> In https://reviews.llvm.org/D24808#571590, @evandro wrote:
>
> > Please, see https://reviews.llvm.org/D24808#554492 and let me know if you need more information.
>
>
> That answers why not move into the DAGCombiner, not why not make it any constant, right?


That comment also has the answer for "why not make it any constant" as well.  Here is what Evandro said:

>   if the target has to materialize the constant for the comparison, it can be used again by the selection


Repository:
  rL LLVM

https://reviews.llvm.org/D24808





More information about the llvm-commits mailing list