[PATCH] D25030: [XRay] Support for for tail calls for ARM no-Thumb
Serge Rogatch via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 18 06:39:28 PDT 2016
rSerge added a comment.
In https://reviews.llvm.org/D25030#572543, @dberris wrote:
> Done @rSerge -- in the future, it would make it much easier/simpler to commit this if you use `arcanist` to create the patches (on git or svn).
> If you're manually making the diffs, please use `-p1` format (have a "before" directory and "after" directory), and run against `clang-format` before uploading. This way we don't introduce whitespace issues that later need to be fixed up (trailing whitespace being the biggest offender).
> If you're using `git` it should be easy to create a patch using `git diff`.
Ok, I'll try to setup one of those. I am making the patches as suggested by the developer policy: `svn diff --diff-cmd=diff -x -U999999 > llvm.diff`
Thanks for delivering!
More information about the llvm-commits