[PATCH] D24824: [mips][FastISel] Instantiate the MipsFastISel class only for targets that support FastISel.

Vasileios Kalintiris via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 06:18:41 PDT 2016

vkalintiris added inline comments.

Comment at: lib/Target/Mips/MipsISelLowering.cpp:464-465
+  // We support only the standard encoding [MIPS32,MIPS32R6) ISAs.
+  bool UseFastISel = TM.Options.EnableFastISel && Subtarget.hasMips32() &&
+                     !Subtarget.hasMips32r6() && !Subtarget.inMips16Mode() &&
sdardis wrote:
> ehostunreach wrote:
> > That was intentional as a coding style, ie. set UseFastISel and use the checks that follow to unset it. I merged the ISA-checks together.
> My request here is that the comment on what ISAs we support doesn't mention MIPS32R6. So that comment should be:
>    // We support only the standard encoding [MIPS32,MIPS32R5] ISAs.
> Otherwise the comments don't quite match the code. IMHO.
Sorry, I didn't understand you initial comment. I updated the review before committing the patch and replaced the MIPS32R6 bit with the MIPS32R5 ISA.



More information about the llvm-commits mailing list