[PATCH] D16697: Updating .debug_line section version information to match DWARF version.

Katya Romanova via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 20:40:18 PDT 2016

kromanova added a comment.

In https://reviews.llvm.org/D16697#569986, @echristo wrote:

> Not sure what to do about the hexagon port - also, what do you have in mind for them to fix this? Check the target?

Hi Eric,
Thank you for the review!

For Hexagon (or any other VLIW architecture) it will be necessary to check the target and implement support for 'op_index' register.  I don’t think I will be the right person to implement support for calculating operation pointer within the bundle for VLIW architectures. I won’t be able to check/test that it works correctly.

I’m also quite concerned that not everyone who cares will actually read this patch. It might break some consumer tools like debuggers and dwarf dumpers, because they are not aware of maximum_operations_per_instruction field. I checked that “main suspects” GDB (version 7.7), readelf (version 2.24), latest llvm-dwarfdump understand maximum_operations_per_instruction; however, obviously, that’s not a complete list of debug info consumers.

Taking all this information into consideration, should I go ahead and commit? I have fixed the typo that you noticed.




More information about the llvm-commits mailing list