[PATCH] D25616: [llvm-readobj] - Teach readobj to print PT_OPENBSD_RANDOMIZE/PT_OPENBSD_WXNEEDED headers.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 19:46:22 PDT 2016

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

LGTM modulo nit.

Comment at: test/tools/llvm-readobj/program-headers.test:154
+OPENBSD-X86-64-NEXT:     MemSize: 8
+OPENBSD-X86-64-NEXT:     Flags [ (0x4)
+OPENBSD-X86-64-NEXT:       PF_R (0x4)
grimar wrote:
> davide wrote:
> > Remove the `(0x4)`, here and in other parts of the patch.
> Ok, though it is not consistent with other places in this file. I also removed all values checking, as
> intention of testcase is to check string name of PHDR and nothing else.

Comment at: test/tools/llvm-readobj/program-headers.test:14
+## test.s is empty file, linker.script was:
+## PHDRS { text PT_LOAD FILEHDR PHDRS; foo 0x65a3dbe6; bar 0x65a3dbe7; }
test.s is an empty file. 


More information about the llvm-commits mailing list